Skip to content

gh-139262: Sometimes keystrokes are swallowed in the new REPL on Windows #139263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-139262: Sometimes keystrokes are swallowed in the new REPL on Windows #139263

wants to merge 2 commits into from

Conversation

chris-eibl
Copy link
Member

@chris-eibl chris-eibl commented Sep 23, 2025 •
edited by bedevere-app bot
Loading

Especially when using the meta (ALT) key.

For instance, Alt + b for

cpython/Lib/_pyrepl/reader.py

Line 85 in 6b4e3fe

(r"\M-b", "backward-word"),

the first hit is swallowed in a Windwos Terminal.

It happens, when there is nothing to be read from the console, i.e.

cpython/Lib/_pyrepl/windows_console.py

Line 569 in 6b4e3fe

def wait(self, timeout: float | None) -> bool:

returns False but there is data in self.event_queue.

@bedevere-app bedevere-app bot mentioned this pull request Sep 23, 2025
Open
chris-eibl
chris-eibl commented Sep 23, 2025
View reviewed changes
Lib/_pyrepl/windows_console.py
return False
return True

def wait(self, timeout: float | None) -> bool:
Copy link
Member Author

@chris-eibl chris-eibl Sep 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is easy and brings us in sync with unix_console.py

cpython/Lib/_pyrepl/unix_console.py

Lines 434 to 441 in 6b4e3fe

def wait(self, timeout: float | None = None) -> bool:
"""
Wait for events on the console.
"""
return (
not self.event_queue.empty()
or bool(self.pollob.poll(timeout))
)
.

@chris-eibl chris-eibl mentioned this pull request Sep 23, 2025
Open
@chris-eibl
Copy link
Member Author

macOS test_ssl failure for sure unrelated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chris-eibl